[Lldb-commits] [lldb] [lldb-dap] Change the launch sequence (PR #138219)

[Jonas Devlieghere via lldb-commits]

JDevlieghere wrote:

> Unblocked!

Thanks!

> > @kusmour Please take another look. In the current state all the test pass (reliably) locally and the linux bot seems happy too. Not sure if we want to keep the test disabled for now or turn them back on and see what the reliability is like on the bots.
> 
> I don't know much about the build bot infra but looks like the only way to get the tests running is to land an enablement patch?

We  have pre-commit  testing (which passed) but that doesn't say much about the reliability. We'll need to enable them to see what the impact is on the post-commit CI. I think I'll split off the test-reenablement into a separate PR so we don't have to revert the whole thing here.

> Looks like a bunch of tests got disabled today: #137660 I don't think we should keep ignoring tests if we want to land this tho. I am all for re-enable them with the risk of reverting. But I will let others to chime in.
> 
> cc. @IanWood1 @felipepiovezan

I don't t think those got disabled today, they're cherrypicks on forks from the upstream commits (the ones I mentioned on Discouse):

- [[lldb][test] Disable a bunch of flakey lldb-dap tests · llvm/llvm-project at 2dbab4c · GitHub](https://github.com/llvm/llvm-project/commit/2dbab4ca8ddb218af555d8d1fd86b72612387582)
- [[lldb] Disable TestDAP_attachByPortNum · llvm/llvm-project at b73169a · GitHub](https://github.com/llvm/llvm-project/commit/b73169ad3edc56fe2b4f5bd3d5259310168da50c)
- [[lldb] Disable TestDAP_attach · llvm/llvm-project at 55b4e5e · GitHub](https://github.com/llvm/llvm-project/commit/55b4e5e5154550ba981af08ca9bd1e3da00e6fea)

https://github.com/llvm/llvm-project/pull/138219