[Lldb-commits] [lldb] [lldb] Inherit DuplicateFileAction(HANDLE, HANDLE) handles on windows (PR #137978)

Dmitry Vasilyev via lldb-commits lldb-commits at lists.llvm.org
Fri May 2 13:39:23 PDT 2025


================
@@ -274,10 +274,8 @@ static Status spawn_process(const char *progname, const FileSpec &prog,
   self_args.AppendArgument(llvm::StringRef("platform"));
   self_args.AppendArgument(llvm::StringRef("--child-platform-fd"));
   self_args.AppendArgument(llvm::to_string(shared_socket.GetSendableFD()));
-#ifndef _WIN32
   launch_info.AppendDuplicateFileAction((int)shared_socket.GetSendableFD(),
                                         (int)shared_socket.GetSendableFD());
----------------
slydiman wrote:

Ok. What about STDIN_FILENO=0? 
Then ProcessLaunchInfo::GetFileActionForFD() must check the action and filter only eFileActionOpen, or filter out eFileActionDuplicate at least.

https://github.com/llvm/llvm-project/pull/137978


More information about the lldb-commits mailing list