[Lldb-commits] [lldb] [lldb-dap] Fix raciness in launch and attach tests (PR #137920)

[via lldb-commits]

kusmour wrote:

> > Technically the response of launch/attach should be the end of the chain.
> 
> Thats not how its implemented in VS Code at least:
> 
> * `initialize` is sent then `launch` or `attach` https://github.com/microsoft/vscode/blob/main/src/vs/workbench/contrib/debug/browser/debugService.ts#L674-L675, these two happen sequentially and its not coordinating this with the `initialized` event or `configurationDone` request.
> * When [`initialized`](https://microsoft.github.io/debug-adapter-protocol/specification#Events_Initialized) is received, it triggers the setBreakpoints then `configurationDone` https://github.com/microsoft/vscode/blob/main/src/vs/workbench/contrib/debug/browser/debugSession.ts#L1063-L1091

Yes but that code doesn't define how adapter should respond to those requests, the specification does. What you showed above doesn't conflict with having the response being the end of the launch sequence and the mark of "the debug session has started". They don't need to coordinate with `initialized` event and they shouldn't. The adapter should use `initialized` to signal it can take breakpoint requests.

https://github.com/llvm/llvm-project/pull/137920