[Lldb-commits] [lldb] [LLDB] Ptrace seize dead process (PR #137041)

[David Spickett via lldb-commits]

================
@@ -1304,6 +1304,9 @@ void GDBRemoteCommunicationServerCommon::
     if (!abi.empty())
       response.Printf("elf_abi:%s;", abi.c_str());
     response.Printf("ptrsize:%d;", proc_arch.GetAddressByteSize());
+    std::optional<bool> non_resumable = proc_info.IsNonResumable();
+    if (non_resumable)
+      response.Printf("non_resumable:%d", *non_resumable);
----------------
DavidSpickett wrote:

This is part of qProcessInfo (https://lldb.llvm.org/resources/lldbgdbremote.html#qprocessinfo) which is, I presume, only requested once because all the information is constant for the process lifetime.

At least for the situation at hand, non-resumeable is also constant. Though the process had to get into that state somehow, but if you were debugging it before the non-resumable point, it wouldn't have got into the non-resumeable state anyway so it makes no difference.

So unless anyone can think of a situation where non-resumeable could change, this packet is probably fine.

https://github.com/llvm/llvm-project/pull/137041