[Lldb-commits] [lldb] [LLDB] Add field member operators to DIL (PR #138093)

[via lldb-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff HEAD~1 HEAD --extensions cpp,h -- lldb/test/API/commands/frame/var-dil/basics/MemberOf/main.cpp lldb/test/API/commands/frame/var-dil/basics/MemberOfAnonymousMember/main.cpp lldb/test/API/commands/frame/var-dil/basics/MemberOfInheritance/main.cpp lldb/include/lldb/ValueObject/DILAST.h lldb/include/lldb/ValueObject/DILEval.h lldb/include/lldb/ValueObject/DILLexer.h lldb/include/lldb/ValueObject/DILParser.h lldb/source/ValueObject/DILAST.cpp lldb/source/ValueObject/DILEval.cpp lldb/source/ValueObject/DILLexer.cpp lldb/source/ValueObject/DILParser.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/lldb/include/lldb/ValueObject/DILAST.h b/lldb/include/lldb/ValueObject/DILAST.h
index a74a12bd8..16ba34fab 100644
--- a/lldb/include/lldb/ValueObject/DILAST.h
+++ b/lldb/include/lldb/ValueObject/DILAST.h
@@ -94,7 +94,7 @@ public:
   MemberOfNode(uint32_t location, ASTNodeUP base, bool is_arrow,
                ConstString name)
       : ASTNode(location, NodeKind::eMemberOfNode), m_base(std::move(base)),
-        m_is_arrow(is_arrow), m_field_name(name) { }
+        m_is_arrow(is_arrow), m_field_name(name) {}
 
   llvm::Expected<lldb::ValueObjectSP> Accept(Visitor *v) const override;
 
diff --git a/lldb/source/ValueObject/DILEval.cpp b/lldb/source/ValueObject/DILEval.cpp
index 1f1ad7161..e5c17fecb 100644
--- a/lldb/source/ValueObject/DILEval.cpp
+++ b/lldb/source/ValueObject/DILEval.cpp
@@ -280,7 +280,8 @@ Interpreter::EvaluateMemberOf(lldb::ValueObjectSP value,
 
   lldb::DynamicValueType use_dynamic =
       (!is_dynamic) ? lldb::eNoDynamicValues : lldb::eDynamicDontRunTarget;
-  // Walk the path from the base value to the value that contains the requested field.
+  // Walk the path from the base value to the value that contains the requested
+  // field.
   for (uint32_t idx : path) {
     member_val_sp = member_val_sp->GetChildAtIndex(idx, /*can_create*/ true);
   }
diff --git a/lldb/source/ValueObject/DILParser.cpp b/lldb/source/ValueObject/DILParser.cpp
index 9c5bc7177..c7008f589 100644
--- a/lldb/source/ValueObject/DILParser.cpp
+++ b/lldb/source/ValueObject/DILParser.cpp
@@ -127,10 +127,9 @@ ASTNodeUP DILParser::ParsePostfixExpression() {
     m_dil_lexer.Advance();
     Token member_token = CurToken();
     std::string member_id = ParseIdExpression();
-    lhs = std::make_unique<MemberOfNode>(member_token.GetLocation(),
-                                         std::move(lhs),
-                                         token.GetKind() == Token::arrow,
-                                         ConstString(member_id));
+    lhs = std::make_unique<MemberOfNode>(
+        member_token.GetLocation(), std::move(lhs),
+        token.GetKind() == Token::arrow, ConstString(member_id));
   }
   return lhs;
 }
diff --git a/lldb/test/API/commands/frame/var-dil/basics/MemberOf/main.cpp b/lldb/test/API/commands/frame/var-dil/basics/MemberOf/main.cpp
index dace888be..755febcdc 100644
--- a/lldb/test/API/commands/frame/var-dil/basics/MemberOf/main.cpp
+++ b/lldb/test/API/commands/frame/var-dil/basics/MemberOf/main.cpp
@@ -1,15 +1,13 @@
-int
-main(int argc, char**argv)
-{
+int main(int argc, char **argv) {
   int x = 2;
   struct Sx {
     int x;
-    int& r;
+    int &r;
     char y;
   } s{1, x, 2};
 
-  Sx& sr = s;
-  Sx* sp = &s;
+  Sx &sr = s;
+  Sx *sp = &s;
 
   Sx sarr[2] = {{5, x, 2}, {1, x, 3}};
 
diff --git a/lldb/test/API/commands/frame/var-dil/basics/MemberOfAnonymousMember/main.cpp b/lldb/test/API/commands/frame/var-dil/basics/MemberOfAnonymousMember/main.cpp
index 6237523ac..c787f29f9 100644
--- a/lldb/test/API/commands/frame/var-dil/basics/MemberOfAnonymousMember/main.cpp
+++ b/lldb/test/API/commands/frame/var-dil/basics/MemberOfAnonymousMember/main.cpp
@@ -1,5 +1,4 @@
-int main(int argc, char** argv)
-{
+int main(int argc, char **argv) {
   struct A {
     struct {
       int x = 1;
@@ -22,7 +21,7 @@ int main(int argc, char** argv)
       int x = 5;
     };
     class {
-     public:
+    public:
       int y = 6;
     };
   } c;
diff --git a/lldb/test/API/commands/frame/var-dil/basics/MemberOfInheritance/main.cpp b/lldb/test/API/commands/frame/var-dil/basics/MemberOfInheritance/main.cpp
index 4d29af1b7..27177f3f0 100644
--- a/lldb/test/API/commands/frame/var-dil/basics/MemberOfInheritance/main.cpp
+++ b/lldb/test/API/commands/frame/var-dil/basics/MemberOfInheritance/main.cpp
@@ -1,5 +1,4 @@
-int main(int argc, char** argv)
-{
+int main(int argc, char **argv) {
   struct A {
     int a_;
   } a{1};
@@ -38,7 +37,7 @@ int main(int argc, char** argv)
   } bat;
   bat.weight_ = 10;
 
- // Empty bases example.
+  // Empty bases example.
   struct IPlugin {
     virtual ~IPlugin() {}
   };
@@ -74,14 +73,14 @@ int main(int argc, char** argv)
   struct Mixin {};
   struct Parent : private Mixin, public Base {
     int z;
-    virtual void Do(){};
+    virtual void Do() {};
   };
   Parent obj;
   obj.x = 1;
   obj.y = 2;
   obj.z = 3;
-  Base* parent_base = &obj;
-  Parent* parent = &obj;
+  Base *parent_base = &obj;
+  Parent *parent = &obj;
 
   return 0; // Set a breakpoint here
 }

``````````

</details>


https://github.com/llvm/llvm-project/pull/138093