[Lldb-commits] [lldb] [lldb] Inherit DuplicateFileAction(HANDLE, HANDLE) handles on windows (PR #137978)

[Dmitry Vasilyev via lldb-commits]

================
@@ -274,10 +274,8 @@ static Status spawn_process(const char *progname, const FileSpec &prog,
   self_args.AppendArgument(llvm::StringRef("platform"));
   self_args.AppendArgument(llvm::StringRef("--child-platform-fd"));
   self_args.AppendArgument(llvm::to_string(shared_socket.GetSendableFD()));
-#ifndef _WIN32
   launch_info.AppendDuplicateFileAction((int)shared_socket.GetSendableFD(),
                                         (int)shared_socket.GetSendableFD());
----------------
slydiman wrote:

Here is the problem. 
AppendDuplicateFileAction() means fd is int. 
But GetSendableFD() returns shared_fd_t = lldb::pipe_t = void * = HANDLE. We cannot just cast HANDLE to int.

https://github.com/llvm/llvm-project/pull/137978