[Lldb-commits] [lldb] [lldb-dap] Add an RAII helper for synchronous mode (NFC) (PR #137900)

[Jonas Devlieghere via lldb-commits]

================
@@ -235,4 +235,15 @@ std::string GetStringValue(const lldb::SBStructuredData &data) {
   return str;
 }
 
+ScopeSyncMode::ScopeSyncMode(lldb::SBDebugger &debugger)
+    : m_debugger(debugger) {
+  assert(m_debugger.GetAsync() && "Debugger not in asynchronous mode!");
----------------
JDevlieghere wrote:

Yeah, that would create all kind of havoc, including triggering this assert. I'm not convinced this is the right place to flag that (and show a warning/error to the user). We should either prevent the user from changing that behind our back, or make sure we always reset it before giving control to lldb-dap. I'll remove the assert from this PR.  

https://github.com/llvm/llvm-project/pull/137900