[Lldb-commits] [lldb] 65b0d21 - [lldb] Remove "error:" prefix from reverse execute error messages

[David Spickett via lldb-commits]

Author: David Spickett
Date: 2025-04-29T14:01:01Z
New Revision: 65b0d21eb490aaa0c742739ce95b1acc654be22b

URL: https://github.com/llvm/llvm-project/commit/65b0d21eb490aaa0c742739ce95b1acc654be22b
DIFF: https://github.com/llvm/llvm-project/commit/65b0d21eb490aaa0c742739ce95b1acc654be22b.diff

LOG: [lldb] Remove "error:" prefix from reverse execute error messages

Errors will get "error:" prefixes automatically so this is not needed.

Added: 
    

Modified: 
    lldb/include/lldb/Target/Process.h
    lldb/source/API/SBProcess.cpp
    lldb/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp
    lldb/source/Plugins/Process/Windows/Common/ProcessWindows.cpp
    lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/include/lldb/Target/Process.h b/lldb/include/lldb/Target/Process.h
index 7bed610b2830d..f5ee01d3fa713 100644
--- a/lldb/include/lldb/Target/Process.h
+++ b/lldb/include/lldb/Target/Process.h
@@ -1114,10 +1114,9 @@ class Process : public std::enable_shared_from_this<Process>,
   virtual Status DoResume(lldb::RunDirection direction) {
     if (direction == lldb::RunDirection::eRunForward)
       return Status::FromErrorStringWithFormatv(
-          "error: {0} does not support resuming processes", GetPluginName());
+          "{0} does not support resuming processes", GetPluginName());
     return Status::FromErrorStringWithFormatv(
-        "error: {0} does not support reverse execution of processes",
-        GetPluginName());
+        "{0} does not support reverse execution of processes", GetPluginName());
   }
 
   /// Called after resuming a process.

diff  --git a/lldb/source/API/SBProcess.cpp b/lldb/source/API/SBProcess.cpp
index ba77b2beed5ea..4de5929d6b230 100644
--- a/lldb/source/API/SBProcess.cpp
+++ b/lldb/source/API/SBProcess.cpp
@@ -590,7 +590,7 @@ SBError SBProcess::ContinueInDirection(RunDirection direction) {
     if (direction == RunDirection::eRunReverse &&
         !process_sp->SupportsReverseDirection())
       return Status::FromErrorStringWithFormatv(
-          "error: {0} does not support reverse execution of processes",
+          "{0} does not support reverse execution of processes",
           GetPluginName());
     process_sp->SetBaseDirection(direction);
   }

diff  --git a/lldb/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp b/lldb/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp
index 60952958cc0d1..3c26afa3d4861 100644
--- a/lldb/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp
+++ b/lldb/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp
@@ -403,8 +403,7 @@ Status ProcessKDP::DoResume(RunDirection direction) {
 
   if (direction == RunDirection::eRunReverse)
     return Status::FromErrorStringWithFormatv(
-        "error: {0} does not support reverse execution of processes",
-        GetPluginName());
+        "{0} does not support reverse execution of processes", GetPluginName());
 
   // Only start the async thread if we try to do any process control
   if (!m_async_thread.IsJoinable())

diff  --git a/lldb/source/Plugins/Process/Windows/Common/ProcessWindows.cpp b/lldb/source/Plugins/Process/Windows/Common/ProcessWindows.cpp
index 331139d029f50..f0c3dd5016139 100644
--- a/lldb/source/Plugins/Process/Windows/Common/ProcessWindows.cpp
+++ b/lldb/source/Plugins/Process/Windows/Common/ProcessWindows.cpp
@@ -242,8 +242,7 @@ Status ProcessWindows::DoResume(RunDirection direction) {
 
   if (direction == RunDirection::eRunReverse) {
     return Status::FromErrorStringWithFormatv(
-        "error: {0} does not support reverse execution of processes",
-        GetPluginName());
+        "{0} does not support reverse execution of processes", GetPluginName());
   }
 
   Status error;

diff  --git a/lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp b/lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp
index bcb9ff238ec57..30fc1955bf4a4 100644
--- a/lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp
+++ b/lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp
@@ -191,8 +191,7 @@ Status ScriptedProcess::DoResume(RunDirection direction) {
     return GetInterface().Resume();
   // FIXME: Pipe reverse continue through Scripted Processes
   return Status::FromErrorStringWithFormatv(
-      "error: {0} does not support reverse execution of processes",
-      GetPluginName());
+      "{0} does not support reverse execution of processes", GetPluginName());
 }
 
 Status ScriptedProcess::DoAttach(const ProcessAttachInfo &attach_info) {