[Lldb-commits] [lldb] [lldb][Format] Make function name frame-format variables work without debug-info (PR #137408)

[Michael Buch via lldb-commits]

Michael137 wrote:

> I think this change broke lldb/test/Shell/Unwind/split-machine-functions.test. I can reproduce locally at HEAD with `ninja check-lldb-shell-unwind`.
> 
> The test binary has a symbol named `_Z3foov.cold` and the test expects the backtrace to print the name of the cold part of the function like this:
> 
> ```
> # SPLIT: frame #1: {{.*}}`foo() (.cold) +
> ```
> 
> but now it gets
> 
> ```
> frame #1: 0x000055555555514f split-machine-functions.test.tmp`foo() + 12
> ```

Ah thanks for the ping. I can see it's failing on the x86 Linux LLDB ubuntu

Yea this case is kind of weird because it's a non-standard mangling extension where the `FunctionEncoding` node gets wrapped in a `DotSuffix`. Let me revert this for now. One way to handle this would be to add a `${function.label-suffix}` frame-format variable.

https://github.com/llvm/llvm-project/pull/137408