[Lldb-commits] [lldb] 82ab359 - [lldb-dap] Fix machine-overridable scope (#137723)
via lldb-commits
lldb-commits at lists.llvm.org
Mon Apr 28 17:01:06 PDT 2025
Author: Jonas Devlieghere
Date: 2025-04-28T17:01:03-07:00
New Revision: 82ab35961f62c8019f3b0129da42c42287a557b0
URL: https://github.com/llvm/llvm-project/commit/82ab35961f62c8019f3b0129da42c42287a557b0
DIFF: https://github.com/llvm/llvm-project/commit/82ab35961f62c8019f3b0129da42c42287a557b0.diff
LOG: [lldb-dap] Fix machine-overridable scope (#137723)
My previous commit was a bit sloppy, I didn't spot that
`lldb-dap.executable-path` already had a scope and I didn't consider
that `lldb-dap.log-path` should have the same scope.
This PR addresses both:
- Fix duplicate scope for `lldb-dap.executable-path`.
- Change scope of `lldb-dap.log-path` to `machine-overridable` too.
Added:
Modified:
lldb/tools/lldb-dap/package.json
Removed:
################################################################################
diff --git a/lldb/tools/lldb-dap/package.json b/lldb/tools/lldb-dap/package.json
index adbb5b2bcf722..5cfd79849b17f 100644
--- a/lldb/tools/lldb-dap/package.json
+++ b/lldb/tools/lldb-dap/package.json
@@ -73,9 +73,8 @@
"title": "lldb-dap",
"properties": {
"lldb-dap.executable-path": {
- "scope": "resource",
- "type": "string",
"scope": "machine-overridable",
+ "type": "string",
"description": "The path to the lldb-dap binary, e.g. /usr/local/bin/lldb-dap"
},
"lldb-dap.arguments": {
@@ -88,7 +87,7 @@
"description": "The list of additional arguments used to launch the debug adapter executable."
},
"lldb-dap.log-path": {
- "scope": "resource",
+ "scope": "machine-overridable",
"type": "string",
"description": "The log path for lldb-dap (if any)"
},
More information about the lldb-commits
mailing list