[Lldb-commits] [lldb] 5afe9c7 - [lldb][lldb-dap] Disable launch tests that rely on get_stdout()

[David Spickett via lldb-commits]

Author: David Spickett
Date: 2025-04-28T09:10:12Z
New Revision: 5afe9c72e4bea2ea38beb1cb0d3a3edc9a958414

URL: https://github.com/llvm/llvm-project/commit/5afe9c72e4bea2ea38beb1cb0d3a3edc9a958414
DIFF: https://github.com/llvm/llvm-project/commit/5afe9c72e4bea2ea38beb1cb0d3a3edc9a958414.diff

LOG: [lldb][lldb-dap] Disable launch tests that rely on get_stdout()

This appears not to work on Windows.

See https://github.com/llvm/llvm-project/issues/137599.

Added: 
    

Modified: 
    lldb/test/API/tools/lldb-dap/launch/TestDAP_launch.py

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/tools/lldb-dap/launch/TestDAP_launch.py b/lldb/test/API/tools/lldb-dap/launch/TestDAP_launch.py
index e20a9db377f7f..931456299e03e 100644
--- a/lldb/test/API/tools/lldb-dap/launch/TestDAP_launch.py
+++ b/lldb/test/API/tools/lldb-dap/launch/TestDAP_launch.py
@@ -11,8 +11,12 @@
 import os
 import re
 
+# Many tests are skipped on Windows because get_stdout() returns None there.
+# Despite the test program printing correctly. See
+# https://github.com/llvm/llvm-project/issues/137599.
 
 class TestDAP_launch(lldbdap_testcase.DAPTestCaseBase):
+    @skipIfWindows
     def test_default(self):
         """
         Tests the default launch of a simple program. No arguments,
@@ -95,6 +99,7 @@ def test_stopOnEntry(self):
                         reason, "breakpoint", 'verify stop isn\'t "main" breakpoint'
                     )
 
+    @skipIfWindows
     def test_cwd(self):
         """
         Tests the default launch of a simple program with a current working
@@ -175,6 +180,7 @@ def test_sourcePath(self):
         self.assertTrue(found, 'found "sourcePath" in console output')
         self.continue_to_exit()
 
+    @skipIfWindows
     def test_disableSTDIO(self):
         """
         Tests the default launch of a simple program with STDIO disabled.
@@ -210,6 +216,7 @@ def test_shellExpandArguments_enabled(self):
                     quote_path, line, 'verify "%s" expanded to "%s"' % (glob, program)
                 )
 
+    @skipIfWindows
     def test_shellExpandArguments_disabled(self):
         """
         Tests the default launch of a simple program with shell expansion
@@ -231,6 +238,7 @@ def test_shellExpandArguments_disabled(self):
                     quote_path, line, 'verify "%s" stayed to "%s"' % (glob, glob)
                 )
 
+    @skipIfWindows
     def test_args(self):
         """
         Tests launch of a simple program with arguments
@@ -255,6 +263,7 @@ def test_args(self):
                 'arg[%i] "%s" not in "%s"' % (i + 1, quoted_arg, lines[i]),
             )
 
+    @skipIfWindows
     def test_environment_with_object(self):
         """
         Tests launch of a simple program with environment variables
@@ -289,6 +298,7 @@ def test_environment_with_object(self):
                 found, '"%s" must exist in program environment (%s)' % (var, lines)
             )
 
+    @skipIfWindows
     def test_environment_with_array(self):
         """
         Tests launch of a simple program with environment variables