[Lldb-commits] [lldb] [lldb-dap] Make lldb-dap.executable-path machine specific (PR #137485)

[via lldb-commits]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-lldb

Author: Jonas Devlieghere (JDevlieghere)

<details>
<summary>Changes</summary>

Change the scope [1] of lldb-dap.executable-path to "machine-overridable":

> Machine specific settings that can be overridden by workspace or
> folder settings.

Practically speaking, this means that the path won't be synced across machines and "(Not synced)" will show up next to the setting. I believe it doesn't make sense to sync this setting (and I remember a bug report where this caused trouble when using VS Code remotely), plus it matches what clangd does for its corresponding setting.

[1] https://code.visualstudio.com/api/references/contribution-points#Configuration-property-schema

---
Full diff: https://github.com/llvm/llvm-project/pull/137485.diff


1 Files Affected:

- (modified) lldb/tools/lldb-dap/package.json (+2-1) 


``````````diff
diff --git a/lldb/tools/lldb-dap/package.json b/lldb/tools/lldb-dap/package.json
index 3957e3f27f297..c25d5033d09f1 100644
--- a/lldb/tools/lldb-dap/package.json
+++ b/lldb/tools/lldb-dap/package.json
@@ -74,7 +74,8 @@
         "lldb-dap.executable-path": {
           "scope": "resource",
           "type": "string",
-          "description": "The path to the lldb-dap binary."
+          "scope": "machine-overridable",
+          "description": "The path to the lldb-dap binary, e.g. /usr/local/bin/lldb-dap"
         },
         "lldb-dap.arguments": {
           "scope": "resource",

``````````

</details>


https://github.com/llvm/llvm-project/pull/137485