[Lldb-commits] [lldb] Skip tests if socket name is longer than 107 bytes (PR #137405)
Emre Kultursay via lldb-commits
lldb-commits at lists.llvm.org
Fri Apr 25 15:07:23 PDT 2025
https://github.com/emrekultursay created https://github.com/llvm/llvm-project/pull/137405
To fix the test failures introduced in Commit 488eeb3
>From d7ab4d2f439e63a6145d83f0017f6e56dd2e37f9 Mon Sep 17 00:00:00 2001
From: Emre Kultursay <emrekultursay at google.com>
Date: Fri, 25 Apr 2025 22:04:28 +0000
Subject: [PATCH] Skip tests if socket name is longer than 107 bytes
To fix the test failures introduced in Commit 488eeb3
---
lldb/unittests/Host/SocketTest.cpp | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/lldb/unittests/Host/SocketTest.cpp b/lldb/unittests/Host/SocketTest.cpp
index 5bfb48b52f7e7..df67943892420 100644
--- a/lldb/unittests/Host/SocketTest.cpp
+++ b/lldb/unittests/Host/SocketTest.cpp
@@ -349,6 +349,10 @@ TEST_F(SocketTest, DomainSocketFromBoundNativeSocket) {
ASSERT_FALSE(EC);
llvm::sys::path::append(name, "test");
+ // Skip the test if the $TMPDIR is too long to hold a domain socket.
+ if (name.size() > 107u)
+ return;
+
DomainSocket socket(true);
Status error = socket.Listen(name, /*backlog=*/10);
ASSERT_THAT_ERROR(error.takeError(), llvm::Succeeded());
@@ -369,6 +373,10 @@ TEST_F(SocketTest, AbstractSocketFromBoundNativeSocket) {
llvm::sys::fs::createUniquePath("AbstractSocketFromBoundNativeSocket", name,
true);
llvm::sys::path::append(name, "test");
+
+ // Skip the test if the $TMPDIR is too long to hold a domain socket.
+ if (name.size() > 107u)
+ return;
AbstractSocket socket;
Status error = socket.Listen(name, /*backlog=*/10);
More information about the lldb-commits
mailing list