[Lldb-commits] [lldb] [lldb-dap] Fix formatting chrono::seconds warning. (PR #137371)

John Harrison via lldb-commits lldb-commits at lists.llvm.org
Fri Apr 25 11:10:00 PDT 2025


https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/137371

>From b509831348617bb67298b5dbcdfad9bcf8f0ca55 Mon Sep 17 00:00:00 2001
From: John Harrison <harjohn at google.com>
Date: Fri, 25 Apr 2025 10:31:18 -0700
Subject: [PATCH] [lldb-dap] Fix formatting chrono::seconds.

---
 lldb/tools/lldb-dap/DAP.cpp | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/lldb/tools/lldb-dap/DAP.cpp b/lldb/tools/lldb-dap/DAP.cpp
index 185b475cfcad6..c21dbbdc6e8ab 100644
--- a/lldb/tools/lldb-dap/DAP.cpp
+++ b/lldb/tools/lldb-dap/DAP.cpp
@@ -35,6 +35,7 @@
 #include "llvm/ADT/StringExtras.h"
 #include "llvm/ADT/StringRef.h"
 #include "llvm/ADT/Twine.h"
+#include "llvm/Support/Chrono.h"
 #include "llvm/Support/Error.h"
 #include "llvm/Support/ErrorHandling.h"
 #include "llvm/Support/FormatVariadic.h"
@@ -968,8 +969,10 @@ lldb::SBError DAP::WaitForProcessToStop(std::chrono::seconds seconds) {
     }
     std::this_thread::sleep_for(std::chrono::microseconds(250));
   }
-  error.SetErrorStringWithFormat("process failed to stop within %lld seconds",
-                                 seconds.count());
+  error.SetErrorString(
+      llvm::formatv("process failed to stop within {0}", seconds)
+          .str()
+          .c_str());
   return error;
 }
 



More information about the lldb-commits mailing list