[Lldb-commits] [lldb] Add symbol locator time for each module in statistics (PR #134563)

[LLVM Continuous Integration via lldb-commits]

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `cross-project-tests-sie-ubuntu` running on `doug-worker-1a` while building `lldb` at step 5 "build-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/181/builds/18362

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 5 (build-unified-tree) failure: build (failure)
...
505.401 [323/8/440] Building CXX object tools/lldb/source/Target/CMakeFiles/lldbTarget.dir/RemoteAwarePlatform.cpp.o
505.448 [322/8/441] Building CXX object tools/lldb/source/Target/CMakeFiles/lldbTarget.dir/RegisterContextUnwind.cpp.o
506.782 [321/8/442] Building CXX object tools/lldb/source/Target/CMakeFiles/lldbTarget.dir/SectionLoadList.cpp.o
508.897 [320/8/443] Building CXX object tools/lldb/source/Target/CMakeFiles/lldbTarget.dir/ScriptedThreadPlan.cpp.o
510.383 [319/8/444] Building CXX object tools/lldb/source/Target/CMakeFiles/lldbTarget.dir/StackFrameList.cpp.o
511.067 [318/8/445] Building CXX object tools/lldb/source/Target/CMakeFiles/lldbTarget.dir/StackFrameRecognizer.cpp.o
511.532 [317/8/446] Building CXX object tools/lldb/source/Target/CMakeFiles/lldbTarget.dir/Process.cpp.o
511.839 [316/8/447] Building CXX object tools/lldb/source/Target/CMakeFiles/lldbTarget.dir/StackFrame.cpp.o
512.581 [315/8/448] Building CXX object tools/lldb/source/Target/CMakeFiles/lldbTarget.dir/StructuredDataPlugin.cpp.o
513.218 [314/8/449] Building CXX object tools/lldb/source/Target/CMakeFiles/lldbTarget.dir/Statistics.cpp.o
FAILED: tools/lldb/source/Target/CMakeFiles/lldbTarget.dir/Statistics.cpp.o 
/opt/ccache/bin/g++ -DGTEST_HAS_RTTI=0 -DHAVE_ROUND -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/build/tools/lldb/source/Target -I/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/lldb/source/Target -I/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/lldb/include -I/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/build/tools/lldb/include -I/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/build/include -I/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/llvm/include -I/usr/include/python3.8 -I/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/llvm/../clang/include -I/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/build/tools/lldb/../clang/include -I/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/lldb/source -I/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/build/tools/lldb/source -isystem /usr/include/libxml2 -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections -Wno-unknown-pragmas -Wno-strict-aliasing -Wno-stringop-truncation -O3 -DNDEBUG  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -std=c++17 -MD -MT tools/lldb/source/Target/CMakeFiles/lldbTarget.dir/Statistics.cpp.o -MF tools/lldb/source/Target/CMakeFiles/lldbTarget.dir/Statistics.cpp.o.d -o tools/lldb/source/Target/CMakeFiles/lldbTarget.dir/Statistics.cpp.o -c /home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/lldb/source/Target/Statistics.cpp
/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/lldb/source/Target/Statistics.cpp: In member function ‘llvm::json::Value lldb_private::ModuleStats::ToJSON() const’:
/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/lldb/source/Target/Statistics.cpp:75:39: error: ‘num_symbols_loaded’ was not declared in this scope
   75 |   module.try_emplace("symbolsLoaded", num_symbols_loaded);
      |                                       ^~~~~~~~~~~~~~~~~~
514.428 [314/7/450] Building CXX object tools/lldb/source/Target/CMakeFiles/lldbTarget.dir/StopInfo.cpp.o
515.376 [314/6/451] Building CXX object tools/lldb/source/Target/CMakeFiles/lldbTarget.dir/SystemRuntime.cpp.o
517.998 [314/5/452] Building CXX object tools/lldb/source/Target/CMakeFiles/lldbTarget.dir/ThreadPlan.cpp.o
518.223 [314/4/453] Building CXX object tools/lldb/source/Target/CMakeFiles/lldbTarget.dir/TargetList.cpp.o
518.917 [314/3/454] Building CXX object tools/lldb/source/Target/CMakeFiles/lldbTarget.dir/ThreadList.cpp.o
519.768 [314/2/455] Building CXX object tools/lldb/source/Target/CMakeFiles/lldbTarget.dir/Thread.cpp.o
526.373 [314/1/456] Building CXX object tools/lldb/source/Target/CMakeFiles/lldbTarget.dir/Target.cpp.o
ninja: build stopped: subcommand failed.

```

</details>

https://github.com/llvm/llvm-project/pull/134563