[Lldb-commits] [lldb] [lldb][lldb-dap] Respect x86 disassembly flavor setting (PR #134722)

Jonas Devlieghere via lldb-commits lldb-commits at lists.llvm.org
Fri Apr 25 09:53:59 PDT 2025


================
@@ -190,6 +190,7 @@ void CommandObjectDisassemble::CommandOptions::OptionParsingStarting(
     // architecture.  For now GetDisassemblyFlavor is really only valid for x86
     // (and for the llvm assembler plugin, but I'm papering over that since that
     // is the only disassembler plugin we have...
+    // this logic is also duplicated in `Handler/DisassembleRequestHandler`
----------------
JDevlieghere wrote:

```suggestion
    // This logic is duplicated in `Handler/DisassembleRequestHandler`.
```

https://github.com/llvm/llvm-project/pull/134722


More information about the lldb-commits mailing list