[Lldb-commits] [lldb] [lldb][lldb-dap] Respect x86 disassembly flavor setting (PR #134722)

[Jonas Devlieghere via lldb-commits]

================
@@ -116,7 +116,25 @@ void DisassembleRequestHandler::operator()(
 
   const auto inst_count =
       GetInteger<int64_t>(arguments, "instructionCount").value_or(0);
-  lldb::SBInstructionList insts = dap.target.ReadInstructions(addr, inst_count);
+
+  std::string flavor_string{};
+  const auto target_triple = llvm::StringRef(dap.target.GetTriple());
+  // this handles both 32 and 64bit x86 architecture.
+  // this logic is also duplicated in
+  // `CommandObjectDisassemble::CommandOptions::OptionParsingStarting`
----------------
JDevlieghere wrote:

```suggestion
  // This handles both 32 and 64bit x86 architecture. The logic is duplicated in
  // `CommandObjectDisassemble::CommandOptions::OptionParsingStarting`
```

https://github.com/llvm/llvm-project/pull/134722