[Lldb-commits] [lldb] [lldb] Emit diagnostics as "important" output (PR #137280)

[Jonas Devlieghere via lldb-commits]

JDevlieghere wrote:

> I also think this LZMA message is important enough to see -- but once, not once for each module. So I can imagine a setup where the first of these messages would cause a popup and the rest would be squirrelled away somewhere -- but for that we'd need a better mechanism to track these.

The methods to emit diagnostics (`ReportError`, `ReportWarning`) already take an optional `std::once_flag`. We have a somewhat similar way of making these errors and warnings very visible in Xcode, so making sure they're not too spammy is something we also care about. I remember several patches (maybe some on the Swift fork) to improve this. In other words, if this needs improving, let's do it at the source. 

https://github.com/llvm/llvm-project/pull/137280