[Lldb-commits] [lldb] 5a64510 - [lldb] Remove redundant DemangledNameInfo::operator==

[Michael Buch via lldb-commits]

Author: Michael Buch
Date: 2025-04-25T10:18:33+01:00
New Revision: 5a645109c3a965dcaab08e3485f2fa505e44cde3

URL: https://github.com/llvm/llvm-project/commit/5a645109c3a965dcaab08e3485f2fa505e44cde3
DIFF: https://github.com/llvm/llvm-project/commit/5a645109c3a965dcaab08e3485f2fa505e44cde3.diff

LOG: [lldb] Remove redundant DemangledNameInfo::operator==

This wasn't defined correctly and was unused. And it was causing a CI
build failure:
```
/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu-dwarf5/llvm-project/lldb/include/lldb/Core/DemangledNameInfo.h: In function ‘bool lldb_private::operator==(const lldb_private::DemangledNameInfo&, const lldb_private::DemangledNameInfo&)’:
/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu-dwarf5/llvm-project/lldb/include/lldb/Core/DemangledNameInfo.h:60:25: error: ‘const struct lldb_private::DemangledNameInfo’ has no member named ‘QualifiersRange’
   60 |                     lhs.QualifiersRange) ==
      |                         ^~~~~~~~~~~~~~~
/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu-dwarf5/llvm-project/lldb/include/lldb/Core/DemangledNameInfo.h:62:25: error: ‘const struct lldb_private::DemangledNameInfo’ has no member named ‘QualifiersRange’
   62 |                     lhs.QualifiersRange);
      |                         ^~~~~~~~~~~~~~~
111.469 [1284/7/3896] Building CXX object tools/lldb/source/Expression/CMakeFiles/lldbExpression.dir/ObjectFileJIT.cpp.o
111.470 [1284/6/3897] Building CXX object tools/lldb/source/Expression/CMakeFiles/lldbExpression.dir/Materializer.cpp.o
111.492 [1284/5/3898] Building CXX object tools/lldb/source/Expression/CMakeFiles/lldbExpression.dir/REPL.cpp.o
111.496 [1284/4/3899] Building CXX object tools/lldb/source/Expression/CMakeFiles/lldbExpression.dir/UserExpression.cpp.o
111.695 [1284/3/3900] Building CXX object tools/lldb/source/Commands/CMakeFiles/lldbCommands.dir/CommandObjectTarget.cpp.o
112.944 [1284/2/3901] Linking CXX shared library lib/libclang.so.21.0.0git
113.098 [1284/1/3902] Linking CXX shared library lib/libclang-cpp.so.21.0git
```

Added: 
    

Modified: 
    lldb/include/lldb/Core/DemangledNameInfo.h

Removed: 
    


################################################################################
diff  --git a/lldb/include/lldb/Core/DemangledNameInfo.h b/lldb/include/lldb/Core/DemangledNameInfo.h
index 3926b45a96f3e..11d3bb58871b8 100644
--- a/lldb/include/lldb/Core/DemangledNameInfo.h
+++ b/lldb/include/lldb/Core/DemangledNameInfo.h
@@ -64,19 +64,6 @@ struct DemangledNameInfo {
     return BasenameRange.second > BasenameRange.first &&
            BasenameRange.second > 0;
   }
-
-  friend bool operator==(const DemangledNameInfo &lhs,
-                         const DemangledNameInfo &rhs) {
-    return std::tie(lhs.BasenameRange, lhs.ArgumentsRange, lhs.ScopeRange,
-                    lhs.QualifiersRange) ==
-           std::tie(rhs.BasenameRange, rhs.ArgumentsRange, rhs.ScopeRange,
-                    lhs.QualifiersRange);
-  }
-
-  friend bool operator!=(const DemangledNameInfo &lhs,
-                         const DemangledNameInfo &rhs) {
-    return !(lhs == rhs);
-  }
 };
 
 /// An OutputBuffer which keeps a record of where certain parts of a