[Lldb-commits] [lldb] 5717c5f - [lldb] Re-enable TestDAP_stackTrace on Windows

[Jonas Devlieghere via lldb-commits]

Author: Jonas Devlieghere
Date: 2025-04-24T21:45:52-07:00
New Revision: 5717c5f385d3b8f5b395c3013aaba9929a618aa3

URL: https://github.com/llvm/llvm-project/commit/5717c5f385d3b8f5b395c3013aaba9929a618aa3
DIFF: https://github.com/llvm/llvm-project/commit/5717c5f385d3b8f5b395c3013aaba9929a618aa3.diff

LOG: [lldb] Re-enable TestDAP_stackTrace on Windows

It's unclear why this test has been disabled on Windows. Remove the
unistd.h header and try re-enabling it.

Added: 
    

Modified: 
    lldb/test/API/tools/lldb-dap/stackTrace/TestDAP_stackTrace.py
    lldb/test/API/tools/lldb-dap/stackTrace/main.c

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/tools/lldb-dap/stackTrace/TestDAP_stackTrace.py b/lldb/test/API/tools/lldb-dap/stackTrace/TestDAP_stackTrace.py
index 3a11df7505994..4e2a76cf76980 100644
--- a/lldb/test/API/tools/lldb-dap/stackTrace/TestDAP_stackTrace.py
+++ b/lldb/test/API/tools/lldb-dap/stackTrace/TestDAP_stackTrace.py
@@ -56,7 +56,6 @@ def verify_stackFrame(self, frame_idx, stackFrame):
             "frame #%i line %i == %i" % (frame_idx, frame_line, expected_line),
         )
 
-    @skipIfWindows
     def test_stackTrace(self):
         """
         Tests the 'stackTrace' packet and all its variants.
@@ -202,7 +201,6 @@ def test_stackTrace(self):
             0, len(stackFrames), "verify zero frames with startFrame out of bounds"
         )
 
-    @skipIfWindows
     def test_functionNameWithArgs(self):
         """
         Test that the stack frame without a function name is given its pc in the response.
@@ -217,7 +215,6 @@ def test_functionNameWithArgs(self):
         frame = self.get_stackFrames()[0]
         self.assertEqual(frame["name"], "recurse(x=1)")
 
-    @skipIfWindows
     def test_StackFrameFormat(self):
         """
         Test the StackFrameFormat.
@@ -239,7 +236,7 @@ def test_StackFrameFormat(self):
         self.assertEqual(frame["name"], "recurse(x=1)")
 
         frame = self.get_stackFrames(format={"parameters": False, "line": True})[0]
-        self.assertEqual(frame["name"], "main.c:6:5 recurse")
+        self.assertEqual(frame["name"], "main.c:5:5 recurse")
 
         frame = self.get_stackFrames(format={"parameters": False, "module": True})[0]
         self.assertEqual(frame["name"], "a.out recurse")

diff  --git a/lldb/test/API/tools/lldb-dap/stackTrace/main.c b/lldb/test/API/tools/lldb-dap/stackTrace/main.c
index 25d81be08e778..1b3d6bb865564 100644
--- a/lldb/test/API/tools/lldb-dap/stackTrace/main.c
+++ b/lldb/test/API/tools/lldb-dap/stackTrace/main.c
@@ -1,5 +1,4 @@
 #include <stdio.h>
-#include <unistd.h>
 
 int recurse(int x) {
   if (x <= 1)