[Lldb-commits] [lldb] [lldb-dap] Show assembly depending on `stop-disassembly-display` settings (PR #136494)

[Ely Ronnen via lldb-commits]

================
@@ -163,6 +163,19 @@ GetEnvironmentFromArguments(const llvm::json::Object &arguments) {
   return envs;
 }
 
+std::string GetStopDisassemblyDisplay(lldb::SBDebugger &debugger) {
+  lldb::SBStructuredData result =
+      debugger.GetSetting("stop-disassembly-display");
+  const size_t result_length = result.GetStringValue(nullptr, 0);
+  if (result_length > 0) {
+    std::string result_string(result_length, '\0');
+    result.GetStringValue(result_string.data(), result_length + 1);
+    return result_string;
+  }
+
+  return "no-debuginfo";
----------------
eronnen wrote:

not sure I understand the suggestion, do you mean having an alternative setting in the lldb-dap launch configuration and use it instead of `debugger.GetSetting`, or just export the existing `StopDisassemblyType` enum and convert the current `GetSetting` to use it?

https://github.com/llvm/llvm-project/pull/136494