[Lldb-commits] [lldb] Add commands to list/enable/disable plugins (PR #134418)

[David Peixotto via lldb-commits]

dmpots wrote:


> > 1. Are we ok to start with a static table of plugin namespaces or do we want dynamic registration from the beginning?
> >    [Add commands to list/enable/disable plugins #134418 (comment)](https://github.com/llvm/llvm-project/pull/134418#discussion_r2029164327)
> 
> If you're committed to supporting the dynamic registration, I don't mind doing it incrementally.

Sounds good. I think it should be easy to add later and would be good to have a few instances to use as an example.


> > 2. Are we ok adding the disabled plug-in info to the "statistics dump" output, or do we want it as part of the version dump?
> >    [Add commands to list/enable/disable plugins #134418 (comment)](https://github.com/llvm/llvm-project/pull/134418#issuecomment-2784151621)
> 
> That sounds like a good idea. Jim made a similar point that if LLDB behaves oddly when you have a plugin disabled, that should be as obvious as possible. We don't currently collect this information automatically, but they seem like a natural place to note this.

I agree adding to stats makes sense. Will update the PR to do it.

> > 3. Do we want a separate command for this, or should we do this with "settings set"?
> >    [Add commands to list/enable/disable plugins #134418 (review)](https://github.com/llvm/llvm-project/pull/134418#pullrequestreview-2747662941)
> 
> I'm on the fence on this one. I like Greg's suggestion of reusing something existing. If everything you care about can be done with the existing setting infrastructure, i.e. enabling/disabling and showing whether they're on or off, then I think we should reuse them. If you need more information and a dedicated dump command, then I'd make this its own command so that everything related to the plugins lives together. The latter has the advantage of being slightly more future proof, at the cost of not following the existing settings paradigm.

I think we do want a separate dump command at least to be able to show the plugin order which is useful in understanding how the debugger works and makes the plugin discovery easier. @clayborg what do you think?


https://github.com/llvm/llvm-project/pull/134418