[Lldb-commits] [lldb] [lldb] Do not bump memory modificator ID when "internal" debugger memory is updated (PR #129092)
David Spickett via lldb-commits
lldb-commits at lists.llvm.org
Wed Apr 23 03:50:24 PDT 2025
DavidSpickett wrote:
Jonas is added as he's listed as the code owner for this area, but does not necessarily review all PRs.
In general, you only need one approval - https://llvm.org/docs/CodeReview.html#lgtm-how-a-patch-is-accepted
Unless you happen to know or suspect others would want to comment, but this is easy to get wrong so don't worry too much about that. Fine to ask, folks can always say they have no opinion.
I assume you don't have the ability to merge this PR yourself? I expect not given it's your first PR here.
Since you already asked @JDevlieghere, they might as well glance at it but I expect Jim's review is enough and Jonas can just merge this.
https://github.com/llvm/llvm-project/pull/129092
More information about the lldb-commits
mailing list