[Lldb-commits] [lldb] [lldb] Upgrade `GetIndexOfChildWithName` to use `llvm::Expected` (PR #136693)

[Michael Buch via lldb-commits]

================
@@ -202,8 +202,13 @@ class VariantFrontEnd : public SyntheticChildrenFrontEnd {
     Update();
   }
 
-  size_t GetIndexOfChildWithName(ConstString name) override {
-    return formatters::ExtractIndexFromString(name.GetCString());
+  llvm::Expected<size_t> GetIndexOfChildWithName(ConstString name) override {
+    size_t index = formatters::ExtractIndexFromString(name.GetCString());
+    if (index == UINT32_MAX) {
+      return llvm::createStringError("Cannot find index of child '%s'",
+                                     name.AsCString());
+    }
+    return index;
----------------
Michael137 wrote:

This should all just become:
```suggestion
return formatters::ExtractIndexFromString(name.GetCString());
```

Once `ExtractIndexFromString` returns an `llvm::Expected`

https://github.com/llvm/llvm-project/pull/136693