[Lldb-commits] [lldb] [lldb/DWARF] Remove "range lower than function low_pc" check (PR #132395)

[David Spickett via lldb-commits]

================
@@ -42,6 +27,21 @@ look_me_up:
         .size   foo.__part.1, .Lfoo.__part.1_end-foo.__part.1
 
 
+bar:
+        nop
+.Lbar_end:
+        .size   bar, .Lbar_end-bar
+
+        .type   foo, at function
+foo:
----------------
DavidSpickett wrote:

Trying to understand the change here.

I think what you have done is moved them around so that the order is:
foo.__part.1
bar
foo

"look_me_up" is inside of foo.__part.1, which puts it below foo. Previously this would have lead to the error, but not it does not.

Either because look_me_up's range would be below foo's low pc, or same thing for foo.__part.1, not sure which.

https://github.com/llvm/llvm-project/pull/132395