[Lldb-commits] [lldb] [lldb/DWARF] Remove "range lower than function low_pc" check (PR #132395)

[David Spickett via lldb-commits]

DavidSpickett wrote:

I think this relates to:
> 2.17 Code Addresses, Ranges and Base Addresses
> <...>
> The base address of the scope for any of the debugging information entries listed
> above is given by either the DW_AT_low_pc attribute or the first address in the
> first range entry in the list of ranges given by the DW_AT_ranges attribute. If
> there is no such attribute, the base address is undefined.

(https://dwarfstd.org/doc/DWARF5.pdf)

I'm just guessing here that the functions you refer to have both. It doesn't say which should win, but we can take "or" to mean "whichever actually makes sense", and in these cases you'd assume that low_pc is maybe the entry point of the function not the actual lowest PC value some block of it sits at.

Is that roughly the logic of this change? Sounds like the check itself was not 100% correct to begin with, perhaps it was for some previous standard version.

https://github.com/llvm/llvm-project/pull/132395