[Lldb-commits] [lldb] [lldb] Upgrade `GetIndexOfChildWithName` to use `llvm::Expected` (PR #136693)

[Michael Buch via lldb-commits]

================
@@ -489,7 +490,13 @@ llvm::Error Interpret(std::vector<ControlStackElement> &control,
         TYPE_CHECK(Object, String);
         auto name = data.Pop<std::string>();
         POP_VALOBJ(valobj);
-        data.Push((uint64_t)valobj->GetIndexOfChildWithName(name));
+        auto index_or_err = valobj->GetIndexOfChildWithName(name);
+        if (!index_or_err) {
+          data.Push(ValueObjectConstResult::Create(
+              nullptr, Status::FromError(index_or_err.takeError())));
+          break;
+        }
+        data.Push((uint64_t)*index_or_err);
----------------
Michael137 wrote:

```suggestion
        auto index_or_err = valobj->GetIndexOfChildWithName(name);
        if (!index_or_err)
          return index_or_err.takeError();

        data.Push((uint64_t)*index_or_err);
```

https://github.com/llvm/llvm-project/pull/136693