[Lldb-commits] [lldb] [lldb] Upgrade `GetIndexOfChildWithName` to use `llvm::Expected` (PR #136693)

[Michael Buch via lldb-commits]

================
@@ -704,13 +704,17 @@ SBValue SBValue::GetChildAtIndex(uint32_t idx,
 uint32_t SBValue::GetIndexOfChildWithName(const char *name) {
   LLDB_INSTRUMENT_VA(this, name);
 
-  uint32_t idx = UINT32_MAX;
   ValueLocker locker;
   lldb::ValueObjectSP value_sp(GetSP(locker));
   if (value_sp) {
-    idx = value_sp->GetIndexOfChildWithName(name);
+    auto idx_or_err = value_sp->GetIndexOfChildWithName(name);
+    if (!idx_or_err) {
+      llvm::consumeError(idx_or_err.takeError());
+      return UINT32_MAX;
+    }
+    return *idx_or_err;
----------------
Michael137 wrote:

```suggestion
    if (auto idx_or_err = value_sp->GetIndexOfChildWithName(name)) {
      return *idx_or_err;
    else
      llvm::consumeError(idx_or_err.takeError());
```
feels a bit easier to read

https://github.com/llvm/llvm-project/pull/136693