[Lldb-commits] [lldb] fallback to assembly when source code is not available (PR #136494)

[Jason Molenda via lldb-commits]

jasonmolenda wrote:

One side note, I was commenting while not 100% awake and didn't realize this was only in the DAP side of the codebase, I have less weight to argue one way or the other there.  After I posted that I was like, I wonder why I didn't see the `stop-assembly-display` preference used around that diff.  :)   

My comment is much weaker when it's only impacting the DAP replies, fwiw.  I think from a UI perspective defaulting to not showing assembly when we have filename & line number is the best tradeoff for users, but like most UI things it's debatable.  I think using `stop-assembly-display` here would be a good thing for sure.  If people think that the DAP front end should  default to showing assembly in this case, I don't have a strong opinion on that, I haven't lived on those IDEs myself and I don't feel qualified to say anything.

https://github.com/llvm/llvm-project/pull/136494