[Lldb-commits] [lldb] [lldb] Remove CompilerType::GetIndexOfFieldWithName (PR #135963)

Charles Zablit via lldb-commits lldb-commits at lists.llvm.org
Wed Apr 16 11:29:03 PDT 2025


charles-zablit wrote:

> We probably shouldnt be removing the test. Is there some way to test whatever we used to test without the API?

I see 2 options:

1. Move the body of `CompilerType::GetIndexOfFieldWithName` into the test directly. This way, we remove the API but keep the test.
2. Keep the API, use `llvm::Expected` and keep the test.

I feel like `1` would be `hiding` the API, and I would therefore prefer `2`.

https://github.com/llvm/llvm-project/pull/135963


More information about the lldb-commits mailing list