[Lldb-commits] [lldb] [lldb][lldb-dap] Respect x86 disassembly flavor setting (PR #134722)

Walter Erquinigo via lldb-commits lldb-commits at lists.llvm.org
Wed Apr 16 08:14:40 PDT 2025


================
@@ -116,7 +116,22 @@ void DisassembleRequestHandler::operator()(
 
   const auto inst_count =
       GetInteger<int64_t>(arguments, "instructionCount").value_or(0);
-  lldb::SBInstructionList insts = dap.target.ReadInstructions(addr, inst_count);
+
+  std::string flavor_string{};
+  const auto target_triple = llvm::StringRef(dap.target.GetTriple());
+  if (target_triple.starts_with("x86_64") || target_triple.starts_with("x86")) {
----------------
walter-erquinigo wrote:

well, you only need that second check

https://github.com/llvm/llvm-project/pull/134722


More information about the lldb-commits mailing list