[Lldb-commits] [lldb] [DRAFT][lldb] Upgrade CompilerType::GetIndexOfFieldWithName to return llvm::Expected (PR #135963)

[Michael Buch via lldb-commits]

https://github.com/Michael137 commented:

Is this API used for anything outside of that `PlatformSigInfoTest`? It doesn't seem to be used anywhere (including the apple fork). Should we just remove this API?

If we do want to keep it, we could add a test for this in `lldb/unittests/Symbol/TestTypeSystemClang.cpp`. You can create a custom `CompilerType` (search in that file for `CreateRecordType`) and then call `GetIndexOfFieldWithName` on it with some non-existent field name.

https://github.com/llvm/llvm-project/pull/135963