[Lldb-commits] [lldb] [lldb][AIX] get host info for AIX (PR #134354)
Hemang Gadhavi via lldb-commits
lldb-commits at lists.llvm.org
Mon Apr 14 06:13:58 PDT 2025
HemangGadhavi wrote:
> > > We have a tests for this function in `unittests/Host/linux/HostTest.cpp` and it looks like at least some of it should apply to other systems as well. We could move it to the "posix" folder so that it applies to your code as well. Depending on the size of linux-specific parts, we could either keep them in the "linux" folder, or `#ifdef` them out
> >
> >
> > Okay, we will create new PR to either move it to posix or we can create `HostTest.cpp` for aix separately. @labath or you want me to drop the testcase changes in same PR ?
>
> Let's do that here. The PR is small (as it should be) and it's good to have tests together with the code being tested.
Hi @labath
I moved the `unittests/Host/linux/HostTest.cpp` & `SupportTest.cpp` under the `unittests/Host/posix/`, so that unix-like system can used it.
Also I have `#ifdef` out some of the tests, which are not applicable for AIX and tested on Linux/AIX all testcases are passed .
Please review it and give you comments.
Thanks
https://github.com/llvm/llvm-project/pull/134354
More information about the lldb-commits
mailing list