[Lldb-commits] [lldb] cbbf562 - [lldb][Format][NFC] Remove unused FormatEntity::FormatCString

[Michael Buch via lldb-commits]

Author: Michael Buch
Date: 2025-04-14T13:42:35+01:00
New Revision: cbbf562d1c2a076de83d50fedfee78acfb4d8003

URL: https://github.com/llvm/llvm-project/commit/cbbf562d1c2a076de83d50fedfee78acfb4d8003
DIFF: https://github.com/llvm/llvm-project/commit/cbbf562d1c2a076de83d50fedfee78acfb4d8003.diff

LOG: [lldb][Format][NFC] Remove unused FormatEntity::FormatCString

One can use `FormatStringRef` instead anyway

Added: 
    

Modified: 
    lldb/include/lldb/Core/FormatEntity.h
    lldb/source/Core/FormatEntity.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/include/lldb/Core/FormatEntity.h b/lldb/include/lldb/Core/FormatEntity.h
index 51e9ce37e54e7..c3f147ea3a7a2 100644
--- a/lldb/include/lldb/Core/FormatEntity.h
+++ b/lldb/include/lldb/Core/FormatEntity.h
@@ -217,11 +217,6 @@ bool FormatStringRef(const llvm::StringRef &format, Stream &s,
                      const Address *addr, ValueObject *valobj,
                      bool function_changed, bool initial_function);
 
-bool FormatCString(const char *format, Stream &s, const SymbolContext *sc,
-                   const ExecutionContext *exe_ctx, const Address *addr,
-                   ValueObject *valobj, bool function_changed,
-                   bool initial_function);
-
 Status Parse(const llvm::StringRef &format, Entry &entry);
 
 Status ExtractVariableInfo(llvm::StringRef &format_str,

diff  --git a/lldb/source/Core/FormatEntity.cpp b/lldb/source/Core/FormatEntity.cpp
index 23e5999bd80cb..fc4359d7d310a 100644
--- a/lldb/source/Core/FormatEntity.cpp
+++ b/lldb/source/Core/FormatEntity.cpp
@@ -1235,23 +1235,6 @@ bool FormatEntity::FormatStringRef(const llvm::StringRef &format_str, Stream &s,
   return false;
 }
 
-bool FormatEntity::FormatCString(const char *format, Stream &s,
-                                 const SymbolContext *sc,
-                                 const ExecutionContext *exe_ctx,
-                                 const Address *addr, ValueObject *valobj,
-                                 bool function_changed, bool initial_function) {
-  if (format && format[0]) {
-    FormatEntity::Entry root;
-    llvm::StringRef format_str(format);
-    Status error = FormatEntity::Parse(format_str, root);
-    if (error.Success()) {
-      return FormatEntity::Format(root, s, sc, exe_ctx, addr, valobj,
-                                  function_changed, initial_function);
-    }
-  }
-  return false;
-}
-
 bool FormatEntity::Format(const Entry &entry, Stream &s,
                           const SymbolContext *sc,
                           const ExecutionContext *exe_ctx, const Address *addr,