[Lldb-commits] [lldb] [llvm] [CI] monolithic-linux improvements (PR #135499)

[Aiden Grossman via lldb-commits]

================
@@ -49,17 +52,31 @@ trap at-exit EXIT
 
 projects="${1}"
 targets="${2}"
+runtimes="${3}"
 
 lit_args="-v --xunit-xml-output ${BUILD_DIR}/test-results.xml --use-unique-output-file-name --timeout=1200 --time-tests"
 
 echo "--- cmake"
 export PIP_BREAK_SYSTEM_PACKAGES=1
+
 pip install -q -r "${MONOREPO_ROOT}"/mlir/python/requirements.txt
 pip install -q -r "${MONOREPO_ROOT}"/lldb/test/requirements.txt
 pip install -q -r "${MONOREPO_ROOT}"/.ci/requirements.txt
+
+# This is an lldb requirement which is not listed above.
+pip install -q swig
+
+# Set the system llvm-symbolizer as preferred.
+export LLVM_SYMBOLIZER_PATH=`which llvm-symbolizer`
+[[ ! -f "${LLVM_SYMBOLIZER_PATH}" ]] && echo "llvm-symbolizer not found!"
+
+# Set up all runtimes either way. libcxx is a dependency of LLDB.
----------------
boomanaiden154 wrote:

I'm not saying that the tests aren't useful. But we presumably have to build the runtimes and then run additional tests. Throughput is pretty important to think about for premerge given we have limited compute, the frequency of commits, and how much testing we are already doing.

Could you collect timing data (preferrably n=3) on testing a lldb change?

https://github.com/llvm/llvm-project/pull/135499