[Lldb-commits] [lldb] [llvm] [CI] monolithic-linux improvements (PR #135499)

[Matheus Izvekov via lldb-commits]

================
@@ -49,17 +52,31 @@ trap at-exit EXIT
 
 projects="${1}"
 targets="${2}"
+runtimes="${3}"
 
 lit_args="-v --xunit-xml-output ${BUILD_DIR}/test-results.xml --use-unique-output-file-name --timeout=1200 --time-tests"
 
 echo "--- cmake"
 export PIP_BREAK_SYSTEM_PACKAGES=1
+
 pip install -q -r "${MONOREPO_ROOT}"/mlir/python/requirements.txt
 pip install -q -r "${MONOREPO_ROOT}"/lldb/test/requirements.txt
 pip install -q -r "${MONOREPO_ROOT}"/.ci/requirements.txt
+
+# This is an lldb requirement which is not listed above.
+pip install -q swig
+
+# Set the system llvm-symbolizer as preferred.
+export LLVM_SYMBOLIZER_PATH=`which llvm-symbolizer`
+[[ ! -f "${LLVM_SYMBOLIZER_PATH}" ]] && echo "llvm-symbolizer not found!"
+
+# Set up all runtimes either way. libcxx is a dependency of LLDB.
----------------
mizvekov wrote:

I am not sure what impact you mean. This patch does not cause any extra tests to be run, lldb testing is still disabled.

There might be small differences in relation to configure time and installing dependencies, but should be few seconds.

Now if lldb gets added back, then a few extra tests are run, but some of that is offset by the fact libcxx will be only built once instead of twice.

Also that the extra lldb tests being run are the ones that are actually useful for clang.


https://github.com/llvm/llvm-project/pull/135499