[Lldb-commits] [lldb] [lldb] Remove ProcessRunLock::TrySetRunning (PR #135455)

via lldb-commits lldb-commits at lists.llvm.org
Fri Apr 11 16:41:10 PDT 2025


================
@@ -1325,9 +1323,9 @@ void Process::SetPublicState(StateType new_state, bool restarted) {
 Status Process::Resume() {
   Log *log(GetLog(LLDBLog::State | LLDBLog::Process));
   LLDB_LOGF(log, "(plugin = %s) -- locking run lock", GetPluginName().data());
-  if (!m_public_run_lock.TrySetRunning()) {
-    LLDB_LOGF(log, "(plugin = %s) -- TrySetRunning failed, not resuming.",
-             GetPluginName().data());
+  if (!m_public_run_lock.SetRunning()) {
+    LLDB_LOGF(log, "(plugin = %s) -- SetRunning failed, not resuming.",
+              GetPluginName().data());
     return Status::FromErrorString(
         "Resume request failed - process still running.");
----------------
jimingham wrote:

To be really accurate, this should be:

Resume request failed - process was already running."

https://github.com/llvm/llvm-project/pull/135455


More information about the lldb-commits mailing list