[Lldb-commits] [lldb] [lldb] Make SBProcess thread related actions listen to StopLocker (PR #134339)

via lldb-commits lldb-commits at lists.llvm.org
Fri Apr 11 13:25:20 PDT 2025


================
@@ -52,8 +64,14 @@ void ConfigurationDoneRequestHandler::operator()(
   dap.configuration_done_sent = true;
   if (dap.stop_at_entry)
     SendThreadStoppedEvent(dap);
-  else
+  else {
+    // Client requests the baseline of currently existing threads after
+    // a successful launch or attach.
+    // A 'threads' request will be sent after configurationDone response
+    // Obtain the list of threads before we resume the process
----------------
kusmour wrote:

According to DAP

> Please note: a debug adapter is not expected to send this event in response to a request that implies that execution continues, e.g. launch or continue.
It is only necessary to send a continued event if there was no previous request that implied this.

In this case, if the `attach` is expecting the execution continues then we should treat it the same way as `launch`. I am happy to discuss more about this as well as if we should support `stopOnEntry` for attaching :) going forward.

https://github.com/llvm/llvm-project/pull/134339


More information about the lldb-commits mailing list