[Lldb-commits] [lldb] 5b384c3 - [lldb][test] Adjust TestTargetReadInstructionsFlavor skipIfs

David Spickett via lldb-commits lldb-commits at lists.llvm.org
Fri Apr 11 06:15:45 PDT 2025


Author: David Spickett
Date: 2025-04-11T13:14:16Z
New Revision: 5b384c3015100ad815f4d994d7ef35cc947db711

URL: https://github.com/llvm/llvm-project/commit/5b384c3015100ad815f4d994d7ef35cc947db711
DIFF: https://github.com/llvm/llvm-project/commit/5b384c3015100ad815f4d994d7ef35cc947db711.diff

LOG: [lldb][test] Adjust TestTargetReadInstructionsFlavor skipIfs

Original in https://github.com/llvm/llvm-project/pull/134626 was
written as if it was "this or this" but it's "this and this".

So the test ran on AArch64 Linux, because Linux is not Windows.

Split out the Windows check to fix that.

Added: 
    

Modified: 
    lldb/test/API/python_api/target/read-instructions-flavor/TestTargetReadInstructionsFlavor.py

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/python_api/target/read-instructions-flavor/TestTargetReadInstructionsFlavor.py b/lldb/test/API/python_api/target/read-instructions-flavor/TestTargetReadInstructionsFlavor.py
index 40edc57df21ce..12805985798de 100644
--- a/lldb/test/API/python_api/target/read-instructions-flavor/TestTargetReadInstructionsFlavor.py
+++ b/lldb/test/API/python_api/target/read-instructions-flavor/TestTargetReadInstructionsFlavor.py
@@ -7,7 +7,8 @@
 
 
 class TargetReadInstructionsFlavor(TestBase):
-    @skipIf(archs=no_match(["x86_64", "x86", "i386"]), oslist=["windows"])
+    @skipIfWindows
+    @skipIf(archs=no_match(["x86_64", "x86", "i386"]))
     def test_read_instructions_with_flavor(self):
         self.build()
         executable = self.getBuildArtifact("a.out")


        


More information about the lldb-commits mailing list