[Lldb-commits] [lldb] [lldb] Fix SBTarget::ReadInstruction with flavor (PR #134626)

[David Spickett via lldb-commits]

================
@@ -0,0 +1,39 @@
+"""
+Test SBTarget Read Instruction.
+"""
+
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+
+
+class TargetReadInstructionsFlavor(TestBase):
+    @skipIf(archs=no_match(["x86_64", "x86", "i386"]), oslist=["windows"])
----------------
DavidSpickett wrote:

https://lab.llvm.org/buildbot/#/builders/59/builds/15856
```
gmake: Entering directory '/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/lldb-test-build.noindex/python_api/target/read-instructions-flavor/TestTargetReadInstructionsFlavor.test_read_instructions_with_flavor_dwarf'
/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/bin/clang -g -O0   -I/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/llvm-project/lldb/packages/Python/lldbsuite/test/make/../../../../..//include -I/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/tools/lldb/include -I/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/llvm-project/lldb/test/API/python_api/target/read-instructions-flavor -I/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/llvm-project/lldb/packages/Python/lldbsuite/test/make -include /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/llvm-project/lldb/packages/Python/lldbsuite/test/make/test_common.h -fno-limit-debug-info   -MT main.o -MD -MP -MF main.d -c -o main.o /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/llvm-project/lldb/test/API/python_api/target/read-instructions-flavor/main.c
<inline asm>:2:13: error: unknown token in expression
    2 |     movl    %edi, %eax
      |             ^
<inline asm>:2:13: error: invalid operand
    2 |     movl    %edi, %eax
      |             ^
<inline asm>:3:13: error: unknown token in expression
    3 |     addl    %esi, %eax
      |             ^
<inline asm>:3:13: error: invalid operand
    3 |     addl    %esi, %eax
      |             ^
```
I think this skipIf might be doing X and Y, not X or Y. Checking now.

https://github.com/llvm/llvm-project/pull/134626