[Lldb-commits] [lldb] Add locate time and all symbol file path for each module in statistics (PR #134563)

Greg Clayton via lldb-commits lldb-commits at lists.llvm.org
Wed Apr 9 15:18:24 PDT 2025


================
@@ -4267,6 +4269,8 @@ const std::shared_ptr<SymbolFileDWARFDwo> &SymbolFileDWARF::GetDwpSymbolFile() {
       // find the correct DWP file, as the Debuginfod plugin uses *only* this
       // data to correctly match the DWP file with the binary.
       module_spec.GetUUID() = m_objfile_sp->GetUUID();
+      duration.reset();
----------------
clayborg wrote:

You shouldn't reset this right? If we download the .dwp file above and that takes some time, we still want to know the total time it took to locate the file right? What if the first debuginfod locate method takes 500ms to make a failed http request, and then we look again, all of that time should be logged. So don't reset this. To get accurate measurement, use an extra scope above

https://github.com/llvm/llvm-project/pull/134563


More information about the lldb-commits mailing list