[Lldb-commits] [lldb] [NFC][LLDB] Clean up comments/some code in MinidumpFileBuilder (PR #134961)

Jacob Lalonde via lldb-commits lldb-commits at lists.llvm.org
Wed Apr 9 10:55:30 PDT 2025


Jlalond wrote:

> LGTM, though the comment in `AddData` seemed useful, even though it had a couple of typos. Why remove it?

I recently landed changes that did add chunking of the data so the comment was no longer accurate. Now we'll only ever get chunks up to the `MAX_CHUNK_SIZE`

https://github.com/llvm/llvm-project/pull/134961


More information about the lldb-commits mailing list