[Lldb-commits] [lldb] [LLDB][NFC]Also includes the error in log msg. (PR #134922)

Vy Nguyen via lldb-commits lldb-commits at lists.llvm.org
Wed Apr 9 07:14:14 PDT 2025


https://github.com/oontvoo updated https://github.com/llvm/llvm-project/pull/134922

>From ab50c89574613178ba2bf79455eaa8aba0f2205d Mon Sep 17 00:00:00 2001
From: Vy Nguyen <vyng at google.com>
Date: Tue, 8 Apr 2025 15:58:10 -0400
Subject: [PATCH 1/2] [LLDB][NFC]Also includes the error in log msg.

---
 lldb/include/lldb/Core/Telemetry.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lldb/include/lldb/Core/Telemetry.h b/lldb/include/lldb/Core/Telemetry.h
index 28897f283dc55..022f40b1d2f2f 100644
--- a/lldb/include/lldb/Core/Telemetry.h
+++ b/lldb/include/lldb/Core/Telemetry.h
@@ -272,7 +272,8 @@ template <typename Info> struct ScopedDispatcher {
     // And then we dispatch.
     if (llvm::Error er = manager->dispatch(&info)) {
       LLDB_LOG_ERROR(GetLog(LLDBLog::Object), std::move(er),
-                     "Failed to dispatch entry of type: {0}", info.getKind());
+                     "{0} Failed to dispatch entry of type: {1}",
+                     info.getKind());
     }
   }
 

>From 8cbc51eed7cd54240ffcff65d19e4246b01c73de Mon Sep 17 00:00:00 2001
From: Vy Nguyen <vyng at google.com>
Date: Wed, 9 Apr 2025 10:14:06 -0400
Subject: [PATCH 2/2] Update lldb/include/lldb/Core/Telemetry.h

Co-authored-by: Jonas Devlieghere <jonas at devlieghere.com>
---
 lldb/include/lldb/Core/Telemetry.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lldb/include/lldb/Core/Telemetry.h b/lldb/include/lldb/Core/Telemetry.h
index 022f40b1d2f2f..fa01e2e4af90f 100644
--- a/lldb/include/lldb/Core/Telemetry.h
+++ b/lldb/include/lldb/Core/Telemetry.h
@@ -272,7 +272,7 @@ template <typename Info> struct ScopedDispatcher {
     // And then we dispatch.
     if (llvm::Error er = manager->dispatch(&info)) {
       LLDB_LOG_ERROR(GetLog(LLDBLog::Object), std::move(er),
-                     "{0} Failed to dispatch entry of type: {1}",
+                     "Failed to dispatch entry of type {1}: {0}",
                      info.getKind());
     }
   }



More information about the lldb-commits mailing list