[Lldb-commits] [lldb] [lldb][debugserver] Fix an off-by-one error in watchpoint identification (PR #134314)

[LLVM Continuous Integration via lldb-commits]

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `lldb-aarch64-ubuntu` running on `linaro-lldb-aarch64-ubuntu` while building `lldb` at step 6 "test".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/59/builds/15581

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 6 (test) failure: build (failure)
...
PASS: lldb-api :: functionalities/unwind/noreturn/module-end/TestNoReturnModuleEnd.py (687 of 2121)
UNSUPPORTED: lldb-api :: functionalities/unwind/sigtramp/TestSigtrampUnwind.py (688 of 2121)
PASS: lldb-api :: functionalities/unused-inlined-parameters/TestUnusedInlinedParameters.py (689 of 2121)
PASS: lldb-api :: functionalities/unwind/aarch64_unwind_pac/TestAArch64UnwindPAC.py (690 of 2121)
PASS: lldb-api :: functionalities/unwind/noreturn/TestNoreturnUnwind.py (691 of 2121)
PASS: lldb-api :: functionalities/thread/state/TestThreadStates.py (692 of 2121)
PASS: lldb-api :: functionalities/unwind/zeroth_frame/TestZerothFrame.py (693 of 2121)
PASS: lldb-api :: functionalities/value_md5_crash/TestValueMD5Crash.py (694 of 2121)
PASS: lldb-api :: functionalities/valobj_errors/TestValueObjectErrors.py (695 of 2121)
PASS: lldb-api :: functionalities/var_path/TestVarPath.py (696 of 2121)
FAIL: lldb-api :: functionalities/watchpoint/consecutive-watchpoints/TestConsecutiveWatchpoints.py (697 of 2121)
******************** TEST 'lldb-api :: functionalities/watchpoint/consecutive-watchpoints/TestConsecutiveWatchpoints.py' FAILED ********************
Script:
--
/usr/bin/python3.10 /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/llvm-project/lldb/test/API/dotest.py -u CXXFLAGS -u CFLAGS --env LLVM_LIBS_DIR=/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/./lib --env LLVM_INCLUDE_DIR=/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/include --env LLVM_TOOLS_DIR=/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/./bin --arch aarch64 --build-dir /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/lldb-test-build.noindex --lldb-module-cache-dir /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/lldb-test-build.noindex/module-cache-lldb/lldb-api --clang-module-cache-dir /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/lldb-test-build.noindex/module-cache-clang/lldb-api --executable /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/./bin/lldb --compiler /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/./bin/clang --dsymutil /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/./bin/dsymutil --make /usr/bin/gmake --llvm-tools-dir /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/./bin --lldb-obj-root /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/tools/lldb --lldb-libs-dir /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/./lib /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/llvm-project/lldb/test/API/functionalities/watchpoint/consecutive-watchpoints -p TestConsecutiveWatchpoints.py
--
Exit Code: 1

Command Output (stdout):
--
lldb version 21.0.0git (https://github.com/llvm/llvm-project.git revision 21d912121c9f41385b165a736be787527f5bd7c2)
  clang revision 21d912121c9f41385b165a736be787527f5bd7c2
  llvm revision 21d912121c9f41385b165a736be787527f5bd7c2
Skipping the following test categories: ['libc++', 'dsym', 'gmodules', 'debugserver', 'objc']

--
Command Output (stderr):
--
FAIL: LLDB (/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/bin/clang-aarch64) :: test_large_watchpoint (TestConsecutiveWatchpoints.ConsecutiveWatchpointsTestCase)
======================================================================
FAIL: test_large_watchpoint (TestConsecutiveWatchpoints.ConsecutiveWatchpointsTestCase)
   Test watchpoint that covers a large region of memory.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/llvm-project/lldb/test/API/functionalities/watchpoint/consecutive-watchpoints/TestConsecutiveWatchpoints.py", line 58, in test_large_watchpoint
    self.assertTrue(field4_wp.IsValid())
AssertionError: False is not true
Config=aarch64-/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/bin/clang
----------------------------------------------------------------------
Ran 1 test in 0.298s

FAILED (failures=1)

--

********************
UNSUPPORTED: lldb-api :: functionalities/watchpoint/large-watchpoint/TestLargeWatchpoint.py (698 of 2121)
UNSUPPORTED: lldb-api :: functionalities/watchpoint/unaligned-spanning-two-dwords/TestUnalignedSpanningDwords.py (699 of 2121)
PASS: lldb-api :: functionalities/wrong_commands/TestWrongCommands.py (700 of 2121)

```

</details>

https://github.com/llvm/llvm-project/pull/134314