[Lldb-commits] [lldb] [LLDB][NFC] Move CPlusPlusLanguage methods used in Core/Module.cpp to a separated module to break lldb-server dependencies (PR #132274)

[Alex Langford via lldb-commits]

bulbazord wrote:

> That said, I don't think this code should be here (and I think Alex would agree).

I do agree with this.

> > I was referring more to the other items on the list. I assumed, it seems incorrectly, that Alex's patch would fix the dependency in the mangler. It seems like that part still needs to be pluginized, somehow.
> 
> Note Module.cpp still uses `CPlusPlusLanguage::MethodName` in `Module::LookupInfo::Prune()` besides Alex's patch.

These should also be abstracted into plugins then.

We *should* do things "a proper way", otherwise you will see more regressions in size because of innocent changes. It's not the responsibility of contributors to consider the change in size of lldb-server if they cannot reason that their change will impact the size of lldb-server. Until we address the circular dependencies between lldb's "core" libraries (lldbCore, lldbTarget, lldbSymbol, etc.) and lldb's Plugin libraries, I think you will continue playing whack-a-mole to reduce lldb-server's size forever.

https://github.com/llvm/llvm-project/pull/132274