[Lldb-commits] [lldb] [RFC][lldb-dap] Always stop on enrty for attaching (PR #134339)

[via lldb-commits]

================
@@ -73,9 +73,11 @@ void AttachRequestHandler::operator()(const llvm::json::Object &request) const {
   llvm::StringRef core_file = GetString(arguments, "coreFile").value_or("");
   const uint64_t timeout_seconds =
       GetInteger<uint64_t>(arguments, "timeout").value_or(30);
-  dap.stop_at_entry = core_file.empty()
-                          ? GetBoolean(arguments, "stopOnEntry").value_or(false)
-                          : true;
+  // Clients like VS Code sends threads request right after receiving
+  // configurationDone reponse where the process might be resuming.
+  // Getting threads list on a running process is not supported by LLDB.
+  // Always stop the process after attaching.
+  dap.stop_at_entry = true;
----------------
kusmour wrote:

Yes, for attaching users will always see the stop. If you read the [launch.json config](https://github.com/llvm/llvm-project/blob/main/lldb/tools/lldb-dap/README.md?plain=1#L236) for attaching. It actually does not mention this flag at all. So it was doing the attaching without sending stopped event to the IDE by default. However, it still accept this flag if it's presented in the launch.json config.

https://github.com/llvm/llvm-project/pull/134339