[Lldb-commits] [lldb] Revert "[LLDB] Expose checking if the symbol file exists/is loaded via SBModule" (PR #134341)
via lldb-commits
lldb-commits at lists.llvm.org
Thu Apr 3 20:46:29 PDT 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-lldb
Author: Jacob Lalonde (Jlalond)
<details>
<summary>Changes</summary>
Reverts llvm/llvm-project#<!-- -->134163
Reverting while @<!-- -->clayborg and I come up with a better API
---
Full diff: https://github.com/llvm/llvm-project/pull/134341.diff
2 Files Affected:
- (modified) lldb/include/lldb/API/SBModule.h (-3)
- (modified) lldb/source/API/SBModule.cpp (-12)
``````````diff
diff --git a/lldb/include/lldb/API/SBModule.h b/lldb/include/lldb/API/SBModule.h
index 651455bdb78d2..85332066ee687 100644
--- a/lldb/include/lldb/API/SBModule.h
+++ b/lldb/include/lldb/API/SBModule.h
@@ -290,9 +290,6 @@ class LLDB_API SBModule {
lldb::SBAddress GetObjectFileHeaderAddress() const;
lldb::SBAddress GetObjectFileEntryPointAddress() const;
- /// Get if the symbol file for this module is loaded.
- bool IsDebugInfoLoaded() const;
-
/// Get the number of global modules.
static uint32_t GetNumberAllocatedModules();
diff --git a/lldb/source/API/SBModule.cpp b/lldb/source/API/SBModule.cpp
index 4978a553f57c7..985107ec68efd 100644
--- a/lldb/source/API/SBModule.cpp
+++ b/lldb/source/API/SBModule.cpp
@@ -659,18 +659,6 @@ lldb::SBAddress SBModule::GetObjectFileEntryPointAddress() const {
return sb_addr;
}
-bool SBModule::IsDebugInfoLoaded() const {
- LLDB_INSTRUMENT_VA(this);
-
- ModuleSP module_sp(GetSP());
- if (module_sp) {
- SymbolFile *sym_file = module_sp->GetSymbolFile(/*create=*/false);
- return sym_file && sym_file->GetLoadDebugInfoEnabled();
- }
-
- return false;
-}
-
uint32_t SBModule::GetNumberAllocatedModules() {
LLDB_INSTRUMENT();
``````````
</details>
https://github.com/llvm/llvm-project/pull/134341
More information about the lldb-commits
mailing list