[Lldb-commits] [lldb] [RFC][lldb-dap] Always stop on enrty for attaching (PR #134339)
via lldb-commits
lldb-commits at lists.llvm.org
Thu Apr 3 19:54:04 PDT 2025
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff HEAD~1 HEAD --extensions cpp -- lldb/test/API/tools/lldb-dap/attach/multithreading.cpp lldb/tools/lldb-dap/Handler/AttachRequestHandler.cpp
``````````
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/lldb/test/API/tools/lldb-dap/attach/multithreading.cpp b/lldb/test/API/tools/lldb-dap/attach/multithreading.cpp
index 0e9c34091..ae75c503c 100644
--- a/lldb/test/API/tools/lldb-dap/attach/multithreading.cpp
+++ b/lldb/test/API/tools/lldb-dap/attach/multithreading.cpp
@@ -11,7 +11,7 @@ int plus_one(int n) {
}
class ThreadPool {
- public:
+public:
ThreadPool(size_t num_threads = std::thread::hardware_concurrency()) {
for (uint32_t i = 0; i < num_threads; ++i) {
threads.emplace_back(std::thread(&ThreadPool::ThreadLoop, this));
@@ -23,11 +23,11 @@ class ThreadPool {
terminated = true;
}
condition.notify_all();
- for (std::thread& thread : threads) {
+ for (std::thread &thread : threads) {
thread.join();
}
}
- void enqueue(const std::function<void()>& job) {
+ void enqueue(const std::function<void()> &job) {
{
std::unique_lock<std::mutex> lock(queue_mutex);
if (terminated)
@@ -37,7 +37,7 @@ class ThreadPool {
condition.notify_one();
}
- private:
+private:
void ThreadLoop() {
while (true) {
std::function<void()> job;
@@ -80,8 +80,8 @@ int main() {
ThreadPool tp2;
std::cout << "main() running on thread " << std::this_thread::get_id()
<< "\n";
- std::cout
- << "Program is expecting stdin. Please attach debugger and hit enter to continue\n";
+ std::cout << "Program is expecting stdin. Please attach debugger and hit "
+ "enter to continue\n";
std::cin.get();
// At least one of the thread in tp1 will be sceduled with a task twice or
// more if num_jobs is larger than #threads in tp1.
``````````
</details>
https://github.com/llvm/llvm-project/pull/134339
More information about the lldb-commits
mailing list