[Lldb-commits] [lldb] [lldb][AIX] Support for XCOFF Sections (PR #131304)

[Pavel Labath via lldb-commits]

================
@@ -190,8 +190,83 @@ void ObjectFileXCOFF::ParseSymtab(Symtab &lldb_symtab) {}
 
 bool ObjectFileXCOFF::IsStripped() { return false; }
 
-void ObjectFileXCOFF::CreateSections(SectionList &unified_section_list) {}
-
+void ObjectFileXCOFF::CreateSections(SectionList &unified_section_list) {
+
+  if (m_sections_up)
+    return;
+  m_sections_up = std::make_unique<SectionList>();
+  ModuleSP module_sp(GetModule());
+  if (module_sp) {
+    std::lock_guard<std::recursive_mutex> guard(module_sp->GetMutex());
+
+    ModuleSP module_sp(GetModule());
+    for (auto sIdx = m_binary->section_begin(); sIdx != m_binary->section_end();
+         ++sIdx) {
----------------
labath wrote:

Any reason for not using `m_binary->sections64()` here? It seems to offer a much nicer way to access this data... 

https://github.com/llvm/llvm-project/pull/131304