[Lldb-commits] [lldb] [lldb][Target] RunThreadPlan to save/restore the ExecutionContext's frame if one exists (PR #134097)

[Michael Buch via lldb-commits]

Michael137 wrote:

> LGTM. Even the variable name made it clear this wasn't being set correctly. We just usually do evaluate expressions in the selected frame context. This should cause a failure in the current code if you call SBThread.SetSelectedFrame for frame A and then get the SBFrame for another frame and call EvaluateExpression on it? Maybe that would allow you to write a test that fails more directly?

We still need the function pointer stuff (and the ptrauth static initializer code) because that's the only case where we `RunThreadPlan` as part of parsing (before JIT execution)

https://github.com/llvm/llvm-project/pull/134097